`, the JS WILL intercept the click and attempt `fetchContent({page: 0})`, which may return unexpected results. The guard is also needed for next-page arrows on the last page.
### Changes
**`public/assets/js/leads.js` — inside `bindPaginationDelegates()`, add a disabled-link guard after line ~203**
```javascript
// BEFORE
if(!a.closest('.pagination-wrapper, .pagination-links, .group-pagination-links')) return;
// AFTER
if(!a.closest('.pagination-wrapper, .pagination-links, .group-pagination-links')) return;
// Skip disabled pagination links
if(a.closest('li.disabled') || a.classList.contains('disabled')) return;
```
---
## Fix 13 — ML-054, ML-055: Pagination Next/Prev AJAX Navigation
### Root Cause
`bindPaginationDelegates()` intercepts pagination clicks and calls `fetchContent()`. These should work once the other fixes (search/filter) are in place and records load correctly. However, there is one edge case: `fetchContent()` builds the URL from `window.location.href` (line 10) and merges params. If the current URL already has stale `search_text` or `offset` from a prior non-AJAX visit, these persist. This can cause next-page requests to use wrong params.
### Changes
**`public/assets/js/leads.js` — inside `fetchContent()`, ensure filter panel params are merged when paginating**
```javascript
// BEFORE (lines 9–14)
function fetchContent(params={}){
const url = new URL(window.location.href);
url.searchParams.set('tab', activeTab);
url.searchParams.set('view', viewMode);
url.searchParams.set('partial', '1');
Object.entries(params).forEach(([k,v])=>{ if(v!==undefined && v!==null) url.searchParams.set(k,v); });
// AFTER — merge current filter state into all fetches so page changes respect active filters
function fetchContent(params={}){
const url = new URL(window.location.href);
url.searchParams.set('tab', activeTab);
url.searchParams.set('view', viewMode);
url.searchParams.set('partial', '1');
// Merge current filter panel state first so pagination inherits active filters
var filterState = (typeof gatherFilterPanelParams === 'function') ? gatherFilterPanelParams() : {};
Object.entries(filterState).forEach(([k,v])=>{ if(v!==undefined && v!==null && v!=='') url.searchParams.set(k,v); });
// Then merge explicit params (page, offset, etc.) which may override filter state
Object.entries(params).forEach(([k,v])=>{ if(v!==undefined && v!==null) url.searchParams.set(k,v); });
```
> This ensures that when the user goes to page 2, any active search/filter is preserved.
---
## Fix 14 — ML-059: Vertical Scrolling Broken
### Root Cause
The `.cards` wrapper in `layout.blade.php` (line 52) renders with `animate__fadeInUp` animation. On some browsers, animated elements can create a stacking context that interferes with `overflow: visible`. Additionally, the `.leads-table` div uses `table-responsive` which sets `overflow-x: auto` but may clip tall tables on certain screen sizes if a parent has `overflow: hidden`.
### Changes
**`resources/views/admin/leads/partials/table_view.blade.php` — add CSS to allow vertical scroll**
Add at the top of the file (before ``):
```html
@push('page_css')
@endpush
```
---
## Fix 15 — ML-076: Deselect All Columns Breaks Table
### Root Cause
`Helper::configureColumnFilter('LeadController', 'index')` generates a column visibility dropdown. When a user deselects all checkboxes, `dynamicHeaderColumns()` returns an empty `$headers` array. `form-header-fields.blade.php` then renders a `` with only the checkbox and action columns but no data columns, and `form-data-fields.blade.php` renders rows with no data cells, producing a visually broken table with mismatched columns.
### Changes
**`resources/views/admin/components/form-header-fields.blade.php` — add a guard before the `@foreach` (before line 17)**
```blade
@if(empty($headers) || count($headers) === 0)
{{-- Fallback: always show at least the primary identifier column --}}
@else
@foreach ($headers as $key => $val)
... existing th markup ...
@endforeach
@endif
```
**`resources/views/admin/components/form-data-fields.blade.php` — add matching guard**
Wrap the dynamic column cells in the same `@if(empty($headers))` check and render a fallback `| {{ $row->dba ?? $row->id }} | ` when headers are empty.
---
## Fix 16 — ML-081: Responsive Layout Issues
### Root Cause
The `.heading-btn-sec.ipad_column` in `table_view.blade.php` renders the heading buttons in a row but has no `flex-wrap` for small screens, causing overflow on tablet and mobile. The search+select compound control from Fix 2 also needs responsive handling.
### Changes
**`resources/views/admin/leads/partials/table_view.blade.php` — add responsive CSS**
```html
@push('page_css')
@endpush
```
---
## Files Modified
| File | Fixes |
|------|-------|
| `app/Http/Controllers/Leads/LeadController.php` | ML-006, ML-008, ML-023, ML-032, ML-033, ML-034, ML-035, ML-036, ML-037 |
| `app/Models/Leads/Lead.php` | ML-018, ML-034, ML-037 |
| `resources/views/admin/components/header.blade.php` | ML-009, ML-010 |
| `resources/views/admin/components/form-header-fields.blade.php` | ML-015, ML-024–028, ML-076 |
| `resources/views/admin/components/form-data-fields.blade.php` | ML-076 |
| `resources/views/admin/leads/partials/tabs.blade.php` | ML-012 |
| `resources/views/admin/leads/partials/table_view.blade.php` | ML-059, ML-081 |
| `resources/views/admin/leads/partials/table_filter_panel.blade.php` | ML-032–039 (new file) |
| `public/assets/js/leads.js` | ML-006, ML-029, ML-031, ML-024–028, ML-042, ML-043, ML-045, ML-054–056 |
---
## Verification
1. **ML-006** — Type 3+ chars into the table search field → results narrow; autocomplete dropdown appears below the input.
2. **ML-008** — Click the "DBA" dropdown next to the search → options appear (DBA, Email, Phone, Contact Name, etc.); selecting one changes what field is searched.
3. **ML-009** — Bell icon appears in the top navigation; badge shows unread count; clicking opens the Notifications offcanvas panel.
4. **ML-010** — Click username/avatar → dropdown shows Profile, Notification Settings, Calendar Settings, and Logout.
5. **ML-012** — Hover over any tab card (Total Leads, Unassigned Leads, E-Signature Activity, etc.) → Bootstrap tooltip appears showing label and count.
6. **ML-015** — Hover over any table column header → tooltip with the column description appears.
7. **ML-018** — Click "E-Signature Activity" tab → table re-fetches and shows only leads with e-signature activity.
8. **ML-019** — Click "Recently Boarded" tab → table re-fetches and shows only recently boarded leads.
9. **ML-023** — On first load (no user preference set), table shows 25 records; footer shows "1–25 of N".
10. **ML-024** — Click "Created" column header → rows sort ascending; click again → descending; ↑/↓ icon appears in header.
11. **ML-025** — Click "DBA" column header → rows sort A–Z then Z–A.
12. **ML-026** — Click "Status" column header → rows group by status alphabetically.
13. **ML-027** — Click "Status Category" column header → rows sort by category name.
14. **ML-028** — Click "Status Age" column header → rows sort numerically (e.g., 1 < 2 < 10, not alphabetically).
15. **ML-029** — Type a DBA name in the table search field → only matching records show.
16. **ML-031** — Clear the search field (click ✕ icon or delete text) → full list restores; filter count returns to 0.
17. **ML-032** — Click "Filters" button → filter panel slides open/appears below heading.
18. **ML-033** — In filter panel, select a Status → table updates to show only leads with that status.
19. **ML-034** — Select a Status Category → table shows only leads in that category.
20. **ML-035** — Select a Sales Rep # → table shows only leads with that sales rep number.
21. **ML-036** — Select an Assigned User → table shows only leads owned by that user.
22. **ML-037** — Set Created From and Created To dates → table shows only leads created in that range.
23. **ML-038** — Click "Reset Filters" → all filter dropdowns and date inputs clear; full unfiltered list restores.
24. **ML-039** — Apply a combination of filters that matches no records → table shows 0 rows with an empty-state message; no broken layout.
25. **ML-042** — With no rows selected, click Actions → dropdown does NOT open (pointer-events:none blocks it).
26. **ML-043** — Select one or more leads, click Actions → dropdown opens; click "Send Mass SMS" → SMS compose modal opens with correct recipient count.
27. **ML-045** — Select one or more leads, click Actions → click "Send Mass Email" → email compose modal opens.
28. **ML-054** — On page 1 with 25 records, click next-page arrow → page advances; footer shows "26–50 of N".
29. **ML-055** — On page 2+, click previous-page arrow → page returns; footer range updates correctly.
30. **ML-056** — On page 1, the previous-page arrow is visually greyed/disabled; clicking it has no effect.
31. **ML-059** — With many rows in the table, scrolling the page vertically is smooth; no content is clipped.
32. **ML-076** — When all column checkboxes in the column manager are deselected, the table shows a fallback column instead of collapsing entirely.
33. **ML-081** — On a 768px-wide screen (iPad), the heading buttons wrap correctly; no horizontal overflow; filter panel columns stack in two-per-row.